On 01.05.2023 21:30, Jason Andryuk wrote:
> When using HWP, some of the returned data is not applicable. In that
> case, we should just omit it to avoid confusing the user. So switch to
> printing the base and turbo frequencies since those are relevant to HWP.
> Similarly, stop printing the CPU frequencies since those do not apply.
It vaguely feels like I have asked this before: Can you point me at a
place in the SDM where it is said that CPUID 0x16's "Maximum Frequency"
is the turbo frequency? Without such a reference I feel a little uneasy
with ...
> @@ -720,10 +721,15 @@ static void print_cpufreq_para(int cpuid, struct
> xc_get_cpufreq_para *p_cpufreq)
> printf(" %d", p_cpufreq->affected_cpus[i]);
> printf("\n");
>
> - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n",
> - p_cpufreq->cpuinfo_max_freq,
> - p_cpufreq->cpuinfo_min_freq,
> - p_cpufreq->cpuinfo_cur_freq);
> + if ( internal )
> + printf("cpuinfo frequency : base [%u] turbo [%u]\n",
> + p_cpufreq->cpuinfo_min_freq,
> + p_cpufreq->cpuinfo_max_freq);
... calling it "turbo" (and not "max") here.
Jan
> + else
> + printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n",
> + p_cpufreq->cpuinfo_max_freq,
> + p_cpufreq->cpuinfo_min_freq,
> + p_cpufreq->cpuinfo_cur_freq);
>
> printf("scaling_driver : %s\n", p_cpufreq->scaling_driver);
>
