On 08/05/2023 6:14 pm, Olaf Hering wrote: > On a fedora system, if you run `sudo sh install.sh` you break your > system. The installation clobbers /var/run, a symlink to /run. A > subsequent boot fails when /var/run and /run are different since > accesses through /var/run can't find items that now only exist in /run > and vice-versa. > > Skip populating /var/run/xen during make install. > The directory is already created by some scripts. Adjust all remaining > scripts to create XEN_RUN_DIR at runtime. > > XEN_RUN_STORED is covered by XEN_RUN_DIR because xenstored is usually > started afterwards. > > Reported-by: Jason Andryuk <jandr...@gmail.com> > Signed-off-by: Olaf Hering <o...@aepfle.de>
TBH, I think this goes to show how many people do `make install` by hand on a system, rather than using a packaged version. One query... > diff --git a/tools/hotplug/Linux/init.d/xendriverdomain.in > b/tools/hotplug/Linux/init.d/xendriverdomain.in > index c63060f62a..1055d0b942 100644 > --- a/tools/hotplug/Linux/init.d/xendriverdomain.in > +++ b/tools/hotplug/Linux/init.d/xendriverdomain.in > @@ -49,6 +49,7 @@ fi > > do_start () { > echo Starting xl devd... > + mkdir -m700 -p @XEN_RUN_DIR@ Why is this 700, and the others just using regular perms? Also, doesn't it want quoting like the other examples too? ~Andrew