On 23.05.2023 20:14, Andrew Cooper wrote: > On 23/05/2023 5:38 pm, Anthony PERARD wrote: >> CFLAGS is just from Config.mk, instead use the flags used to build >> Xen. >> >> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> >> --- >> >> Notes: >> I don't know if CFLAGS is even useful there, just --version without the >> flags might produce the same result. > > I can't think of any legitimate reason for CFLAGS to be here. > > Any compiler which does differ its output based on CLFAGS is probably > one we don't want to be using...
Well, I wouldn't go quite as far in general, but I agree for the --version case. Actually at least with gcc it's even "better": I've tried a couple of 32-bit compilers with "-m64 --version", which would normally choke on the -m64. But that options is ignored altogether when --version is there. (Which has up- and downsides of course; the command failing might also be useful, in telling us that the compiler isn't usable in the first place.) Jan
