On 16.06.2023 13:47, Olaf Hering wrote: > Wed, 31 May 2023 11:05:52 +0200 Jan Beulich <jbeul...@suse.com>: > >> As said before, num_online_cpus() will under-report for the purpose >> here, as CPUs may have been brought offline, and may be brought online >> again later (independent of the use of "maxcpus="). > > It turned out, commit 74584a367051bc0d6f4b96fd360fa7bc6538fc39 broke > the expected behavior. But to me it is unclear what bug was fixed by > this commit.
Hmm, I find title and description quite clear there. > If I read alloc_trace_bufs correctly, it already operates on online > cpus. And __trace_var will do nothing if called on a cpu which was > not online, t_bufs will likely be NULL. Yielding an incomplete overall trace, at best. > To me it looks like commit 74584a367051bc0d6f4b96fd360fa7bc6538fc39 > could be reverted. I don't think so. I'll add George to Cc as well, as he's the maintainer of this stuff. Jan
