On 20.07.2023 13:20, Roger Pau Monné wrote: > On Thu, Jul 20, 2023 at 12:32:31AM +0000, Volodymyr Babchuk wrote: >> @@ -318,14 +323,17 @@ void vpci_dump_msi(void) >> * holding the lock. >> */
Note the comment here. >> printk("unable to print all MSI-X entries: %d\n", rc); >> - process_pending_softirqs(); >> - continue; >> + goto pdev_done; >> } >> } >> >> spin_unlock(&pdev->vpci->lock); >> + pdev_done: >> + read_unlock(&d->pci_lock); >> process_pending_softirqs(); >> + read_lock(&d->pci_lock); > > read_trylock(). Plus the same scheme as with the spin lock wants following imo: vpci_msix_arch_print() returns an error only with (now) both locks dropped. This then wants reflecting in the comment pointed out above. Jan