On 21.07.2023 19:02, Shawn Anastasio wrote: > Changes in v5: > - (xen/macros.h) Add signoff > - (xen/macros.h) Fix up comment formatting and macro parameter names > - (*.S) Use 8-space column alignment for assembly > - (of-call.S) Add missing space after comma > - (asm-offsets.c) Fix DEFINE() macro formatting > - (asm-offsets.c) Replace _Static_assert with BUILD_BUG_ON
One more general remark / request: Having change logs in cover letters is certainly okay and better than none at all, but for review purposes it is far more useful when provided in the individual patches. Not the least because, as you will likely understand, the larger the series, the harder it is to associate each of the remarks here with individual patches. Jan
