On Tue, 25 Jul 2023, Jan Beulich wrote: > On 25.07.2023 11:17, Nicola Vetrini wrote: > > Rule 5.3 has the following headline: > > "An identifier declared in an inner scope shall not hide an > > identifier declared in an outer scope" > > > > To avoid any confusion resulting from the parameter 'debug' > > hiding the homonymous function declared at > > 'xen/arch/x86/include/asm/processor.h:428' > > the rename of parameters s/debug/lkdbg/ is performed. > > > > Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com> > > --- > > Changes in v2: > > - s/dbg/lkdbg/ > > But only in some of the cases. E.g. ... > > > -static void check_barrier(union lock_debug *debug) > > +static void check_barrier(union lock_debug *dbg) > > ... not here (there are a few more).
I agree with Jan: these are all union lock_debug parameters, so it would make sense to me to use lkdbg everywhere in this patch.
