On 26.07.23 17:50, Jan Beulich wrote:
Hello Jan
> On 26.07.2023 16:14, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com>
>>
>> Without it being present it won't be possible to use some
>> libxl__device_type's callbacks for virtio devices as the common code
>> can only invoke these callbacks (by dereferencing a pointer) for valid
>> libxl__device_type's elements when iterating over device_type_tbl[].
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com>
>> ---
>> tools/libs/light/libxl_create.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/libs/light/libxl_create.c
>> b/tools/libs/light/libxl_create.c
>> index 393c535579..c91059d713 100644
>> --- a/tools/libs/light/libxl_create.c
>> +++ b/tools/libs/light/libxl_create.c
>> @@ -1887,6 +1887,7 @@ const libxl__device_type *device_type_tbl[] = {
>> &libxl__dtdev_devtype,
>> &libxl__vdispl_devtype,
>> &libxl__vsnd_devtype,
>> + &libxl__virtio_devtype,
>> NULL
>> };
>
> From description and nature of the change this looks like a Fixes:
> tag would be warranted.
Looks like, yes. Thanks.
I guess, this should point to the commit that introduced
libxl__virtio_devtype
Fixes: 43ba5202e2ee ('libxl: add support for generic virtio device')
>
> Jan
