On 23/08/2023 16:59, Julien Grall wrote:
Hi,
On 23/08/2023 15:27, Nicola Vetrini wrote:
Directive 4.3 prescribes the following:
"Assembly language shall be encapsulated and isolated",
on the grounds of improved readability and ease of maintenance.
The Directive is violated in this case by asm code in between C code.
A macro is the chosen encapsulation mechanism.
I would rather prefer if we use a static inline.
Just to prevent an possible back and forth on a similar patch:
is it ok to adopt the same approach with the inline asm in
xen/arch/arm/arm64/lib/bitops.c in the definition of the macros
'bitop' and 'testop'?
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
