On Thu, 2023-08-31 at 11:46 +0200, Jan Beulich wrote: > On 30.08.2023 18:57, Oleksii Kurochko wrote: > > asm/vm_event.h is common for ARM and RISC-V so it will be moved to > > asm-generic dir. > > > > Original asm/vm_event.h from ARM was updated: > > * use SPDX-License-Identifier. > > * update comment messages of stubs. > > * update #ifdef. > > * change public/domctl.h to public/vm_event.h. > > > > Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> > > Acked-by: Stefano Stabellini <sstabell...@kernel.org> > > --- > > Changes in V3: > > - add Acked-by: Stefano Stabellini <sstabell...@kernel.org> for > > "xen: move arm/include/asm/vm_event.h to asm-generic" > > - update SPDX tag. > > - move asm/vm_event.h to asm-generic. > > --- > > Changes in V2: > > - change public/domctl.h to public/vm_event.h. > > - update commit message of [PATCH v2 2/2] xen: move > > arm/include/asm/vm_event.h to stubs > > --- > > xen/arch/arm/include/asm/vm_event.h | 66 ---------------------- > > ---- > > xen/include/asm-generic/asm/vm_event.h | 55 +++++++++++++++++++++ > > 2 files changed, 55 insertions(+), 66 deletions(-) > > delete mode 100644 xen/arch/arm/include/asm/vm_event.h > > create mode 100644 xen/include/asm-generic/asm/vm_event.h > > While it's a comment on the first patch, it's really better making > here: > Did you look at Linux? They don't put an intermediate asm/ here. > Instead > see their scripts/Makefile.asm-generic. That way an arch still has > control which generic headers it gets access to, without duplicating > any > of them. Thanks. I'll look at the script.
~ Oleksii
