On 13/09/23 15:14, Julien Grall wrote:
Hi,
On 13/09/2023 13:41, Federico Serafini wrote:
On 13/09/23 14:29, Federico Serafini wrote:
Add missing parameter names and make function declarations and
definitions consistent. No functional change.
Signed-off-by: Federico Serafini <federico.seraf...@bugseng.com>
There is a typo in the patch title (RUles), please correct on commit.
That can be done so long there are no other comments.
Reviewed-by: Federico Serafini <federico.seraf...@bugseng.com>
I am bit confused. Why do you provide a reviewed-by on a patch you wrote?
Cheers,
Since I noticed something wrong with my patch, I thought that adding the
"Reviewed-by" might be better than simply replying to the mail.
I will not do it again.
--
Federico Serafini, M.Sc.
Software Engineer, BUGSENG (http://bugseng.com)