On 14.09.2023 16:56, Oleksii Kurochko wrote: > Based on two patch series [1] and [2], the idea of which is to provide minimal > amount of things for a complete Xen build, a large amount of headers are the > same > or almost the same, so it makes sense to move them to asm-generic. > > Also, providing such stub headers should help future architectures to add > a full Xen build. > > [1] > https://lore.kernel.org/xen-devel/cover.1694543103.git.sanasta...@raptorengineering.com/ > [2] > https://lore.kernel.org/xen-devel/cover.1692181079.git.oleksii.kuroc...@gmail.com/ > > Oleksii Kurochko (29): > xen/asm-generic: introduce stub header spinlock.h
At the example of this, personally I think this goes too far. Headers in asm-generic should be for the case where an arch elects to not implement certain functionality. Clearly spinlocks are required uniformly. Jan