Hi George, > On Sep 25, 2023, at 18:07, George Dunlap <george.dun...@cloud.com> wrote: > > On Mon, Sep 25, 2023 at 10:35 AM Julien Grall <jul...@xen.org> wrote: >> >> Hi Henry, >> >> On 25/09/2023 07:40, Henry Wang wrote: >>>> On Sep 25, 2023, at 14:32, Jan Beulich <jbeul...@suse.com> wrote: >>>> This, for example, would then likely mean >>>> that all Misra work now needs queuing for after the tree re-opens ... >>> >>> …I also thought about this, to be honest I am tempted to loose the control >>> or at least offer some flexibility on this specific part, as normally MISRA >>> related changes are harmless and actually harden the code. I am wondering >>> if there are any objections from others… >>> >>> Committers, would you mind sharing your opinion on this one? Thanks! >> >> I am split. On one hand, I agree they low risk and would be good to have >> them. But on the other hand, they tend to be invasive and may interfere >> with any bug we need to fix during the hardening period. > > *Theoretically* MISRA patches should have no behavioral side effects; > but it's quite possible that they will. I'd be in favor of a more > strict view, that they should all go on a separate branch (or simply > be reviewed in-principle and re-submitted after we branch) now that > the feature freeze is done.
Thanks for sharing your opinion. I definitely understand your concern. I think in Xen Summit we agreed that the release process should not affect the normal code review, so MISRA patches can still be posted to the list and be reviewed. When the staging reopens, these staged MISRA patches can be committed right away. > That's my recommendation, but ultimately I'd leave the decision to Henry. Since this is about MISRA, I would like to wait one more day to see if there is any input from Stefano, otherwise I think Julien’s suggestion is very good so we can just follow that proposed timeline. Kind regards, Henry > > -George
