Hi Stefano, > On Sep 28, 2023, at 07:53, Stefano Stabellini <sstabell...@kernel.org> wrote: > > Actually adding Henry > > On Wed, 27 Sep 2023, Stefano Stabellini wrote: >> Hi Henry, >> >> This patch is now acked. Should it go in 4.18?
Sure, a doc change should be harmless so: Release-acked-by: Henry Wang <henry.w...@arm.com> Kind regards, Henry >> >> In terms of risk of breaking, it is zero as nothing builds or runs based >> on this document. >> >> At the same time, the benefit is also low because the main value of this >> document is for future coding changes that would be too late now for >> 4.18. So the benefits of committing it now are ease of keeping track of >> the change and positive PR when we make the 4.18 release and we talk >> about the total number of MISRA C rules we adopted. >> >> >> >> On Fri, 8 Sep 2023, Stefano Stabellini wrote: >>> From: Stefano Stabellini <stefano.stabell...@amd.com> >>> >>> Add 14.3, with project-wide deviations. >>> >>> Also take the opportunity to clarify that parameters of function pointer >>> types are expected to have names (Rule 8.2). >>> >>> Signed-off-by: Stefano Stabellini <stefano.stabell...@amd.com> >>> --- >>> Changes in v3: >>> - add , >>> - add switch(sizeof(...)) and switch(offsetof(...)) >>> --- >>> docs/misra/rules.rst | 15 ++++++++++++++- >>> 1 file changed, 14 insertions(+), 1 deletion(-) >>> >>> diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst >>> index 34916e266a..ac76e20a9c 100644 >>> --- a/docs/misra/rules.rst >>> +++ b/docs/misra/rules.rst >>> @@ -234,7 +234,8 @@ maintainers if you want to suggest a change. >>> * - `Rule 8.2 >>> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_02.c>`_ >>> - Required >>> - Function types shall be in prototype form with named parameters >>> - - >>> + - Clarification: both function and function pointers types shall >>> + have named parameters. >>> >>> * - `Rule 8.3 >>> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_03.c>`_ >>> - Required >>> @@ -385,6 +386,18 @@ maintainers if you want to suggest a change. >>> - A loop counter shall not have essentially floating type >>> - >>> >>> + * - `Rule 14.3 >>> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_14_03.c>`_ >>> + - Required >>> + - Controlling expressions shall not be invariant >>> + - Due to the extensive usage of IS_ENABLED, sizeof compile-time >>> + checks, and other constructs that are detected as errors by MISRA >>> + C scanners, managing the configuration of a MISRA C scanner for >>> + this rule would be unmanageable. Thus, this rule is adopted with >>> + a project-wide deviation on if, ?:, switch(sizeof(...)), and >>> + switch(offsetof(...)) statements. >>> + >>> + while(0) and while(1) and alike are allowed. >>> + >>> * - `Rule 16.7 >>> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_16_07.c>`_ >>> - Required >>> - A switch-expression shall not have essentially Boolean type >>> -- >>> 2.25.1 >>> >>
