Hi Stefano,
On 29/09/2023 00:19, Stefano Stabellini wrote:
All callers of the bitmap_switch macro (which are all within bitmap.h)
pass an int as first parameter. Do not assign it to an unsigned int
potentially introducing errors.
Signed-off-by: Stefano Stabellini <stefano.stabell...@amd.com>
---
We could also have gone the other way and change all the callers and the
callers' callers to use an unsigned int instead, but I went for the path
of least resistance.
I understand this will solve the issue right now because the callers are
all passing 'int'. However, all the callers will need to switch to
'unsigned int' in order to solve violations in their callers.
That unless we decide to use 'int' everywhere, but I think this is a bad
idea because 'n__' is not supposed to be negative.
Overall, this may be an easy win right now, but this will need to be
reverted. So, I am not happy to ack it and would in fact be leaning
towards Nacking it.
Cheers,
--
Julien Grall
