On Tue, 31 Oct 2023, Julien Grall wrote: > Hi, > > On 31/10/2023 10:31, Jan Beulich wrote: > > On 31.10.2023 10:25, Federico Serafini wrote: > > > Make function defintions and declarations consistent. > > typo: s/defintions/definitions/ > > > > No functional change. > > > > > > Signed-off-by: Federico Serafini <federico.seraf...@bugseng.com> > > > > Acked-by: Jan Beulich <jbeul...@suse.com> > > > > However, ... > > > > > --- > > > Changes in v2: > > > - use 'ptr' do denote a const void * parameter. > > > > ... not even this (let alone the description) clarifies what the > > inconsistency was. I had to go check to figure that x86 already uses > > "ptr". Such things could do with spelling out. > > +1. The more that x86 was the "odd" one but it was chosen to use the variant > everywhere. > > With the commit message clarified: > > Acked-by: Julien Grall <jgr...@amazon.com>
I made the changes on commit to my for-4.19 branch (I am going to wait until staging fully reopens before moving commits to staging).
