On 14.11.23 22:01, Julien Grall wrote:
Hi Juergen,On 13/11/2023 12:43, Juergen Gross wrote:The "-V" (verbose) command line option is nearly completely redundant with "io" tracing. Just the time of the printed data is a little bit different, while the tracing is more informative.The current position of trace_io() is a bit annoying in write_messages() because it will only be called once the message has been fully written to the ring. Can we consider adding a trace_*() when we are about to write? (Or maybe queue the message?)
I'll address that in a future patch by making trace_io() a little bit more flexible. In write_messages() I'm planning to either write a single trace record in case the message could be sent in one go, or split entries for the start and the end of writing the message.
In any case, I think it is odd to enable verbose and tracing separately. So with or without:Reviewed-by: Julien Grall <jgr...@amazon.com>
Thanks, Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
