On 21.11.2023 18:30, Roger Pau Monné wrote:
> On Thu, Nov 16, 2023 at 02:32:07PM +0100, Jan Beulich wrote:
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -2959,7 +2959,7 @@ static bool __init has_if_pschange_mc(vo
>>
>> const struct hvm_function_table * __init start_vmx(void)
>> {
>> - set_in_cr4(X86_CR4_VMXE);
>> + write_cr4(read_cr4() | X86_CR4_VMXE);
>>
>> if ( vmx_vmcs_init() )
>> {
>> @@ -2967,6 +2967,9 @@ const struct hvm_function_table * __init
>> return NULL;
>
> Do we want to also clear VMXE from CR4 here?
Yes, definitely. That was the point of the patch (as far as the BSP is
concerned); I clearly meant to have that there, but then didn't put it
there.
Jan
