On 22/11/2023 3:49 pm, Luca Fancellu wrote: > >> On 21 Nov 2023, at 20:41, Andrew Cooper <andrew.coop...@citrix.com> wrote: >> >> On 21/11/2023 8:33 pm, Luca Fancellu wrote: >>> + CC henry >>> >>>> On 21 Nov 2023, at 20:15, Andrew Cooper <andrew.coop...@citrix.com> wrote: >>>> >>>> -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but >>>> this >>>> logic looks incorrect. It was inherited from the x86 side, where the logic >>>> was redundant and has now been removed. >>>> >>>> In the ARM case it inserts the image name into "xen,xen-bootargs" and >>>> there is >>>> no logic at all to strip this before parsing it as the command line. >>>> >>>> The absence of any logic to strip an image name suggests that it shouldn't >>>> exist there, or having a Xen image named e.g. "hmp-unsafe" in the >>>> filesystem >>>> is going to lead to some unexpected behaviour on boot. >>>> >>>> No functional change. >>>> >>>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >>>> --- >>>> CC: Jan Beulich <jbeul...@suse.com> >>>> CC: Roger Pau Monné <roger....@citrix.com> >>>> CC: Wei Liu <w...@xen.org> >>>> CC: Stefano Stabellini <sstabell...@kernel.org> >>>> CC: Julien Grall <jul...@xen.org> >>>> CC: Volodymyr Babchuk <volodymyr_babc...@epam.com> >>>> CC: Bertrand Marquis <bertrand.marq...@arm.com> >>>> CC: Roberto Bagnara <roberto.bagn...@bugseng.com> >>>> CC: Nicola Vetrini <nicola.vetr...@bugseng.com> >>>> >>>> v2: >>>> * New. >>>> >>>> I'm afraid that all of this reasoning is based on reading the source code. >>>> I >>>> don't have any way to try this out in a real ARM UEFI environment. >>> I will test this one tomorrow on an arm board > I confirm that booting though UEFI on an arm board works > > Reviewed-by: Luca Fancellu <luca.fance...@arm.com> > Tested-by: Luca Fancellu <luca.fance...@arm.com>
Thanks, and you confirmed that the first cmdline parameter is still usable? ~Andrew
