On Tue, 5 Dec 2023, Federico Serafini wrote: > Add missing parameter names to address violations of MISRA C:2012 > Rule 8.2. Furthermore, use C standard types to comply with XEN coding style. > > No functional change. > > Signed-off-by: Federico Serafini <federico.seraf...@bugseng.com> > --- > xen/arch/x86/include/asm/acpi.h | 2 +- > xen/include/acpi/apei.h | 5 +++-- > xen/include/acpi/cpufreq/cpufreq.h | 2 +- > xen/include/acpi/cpufreq/processor_perf.h | 16 ++++++++-------- > 4 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h > index 0df92d3714..d54c105f61 100644 > --- a/xen/arch/x86/include/asm/acpi.h > +++ b/xen/arch/x86/include/asm/acpi.h > @@ -81,7 +81,7 @@ extern bool acpi_lapic, acpi_ioapic, acpi_noirq; > extern bool acpi_force, acpi_ht, acpi_disabled; > extern u32 acpi_smi_cmd; > extern u8 acpi_enable_value, acpi_disable_value; > -void acpi_pic_sci_set_trigger(unsigned int, u16); > +void acpi_pic_sci_set_trigger(unsigned int irq, uint16_t trigger);
There is something strange about this one, I cannot find the definition anywhere. Am I missing anything? Everything else looks good