On Thu, 2023-12-07 at 15:22 +0100, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/iommu.h > > @@ -0,0 +1,7 @@ > > +#ifndef __ASM_RISCV_IOMMU_H__ > > +#define __ASM_RISCV_IOMMU_H__ > > + > > +struct arch_iommu { > > +}; > > + > > +#endif /* __ASM_IOMMU_H__ */ > > Instead of adding this header, didn't we discuss to make the #include > in > xen/iommu.h depend on CONFIG_HAS_PASSTHROUGH? Also - no SPDX or > footer > here? We had discussion about some stuff in device.h, but we can apply it here too. Only to place will be needed to update:
+ #ifdef CONFIG_HAS_PASSTHROUGH #include <asm/iommu.h> + #endif #ifndef iommu_call # define iommu_call(ops, fn, args...) ((ops)->fn(args)) # define iommu_vcall iommu_call #endif struct domain_iommu { + #ifdef CONFIG_HAS_PASSTHROUGH struct arch_iommu arch; + #endif ... I'll do that in the next iteration of this patch series. Thanks. ~ Oleksii