On 15.12.2023 03:43, Shawn Anastasio wrote: > --- /dev/null > +++ b/xen/include/asm-generic/static-shmem.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +#ifndef __ASM_GENERIC_STATIC_SHMEM_H__ > +#define __ASM_GENERIC_STATIC_SHMEM_H__ > + > +static inline int process_shm_node(const void *fdt, int node, > + uint32_t address_cells, uint32_t > size_cells) > +{ > + return -EINVAL; > +}
This talking of fdt and cells doesn't look very generic to me, I'm afraid. Plus if such a header was introduced, I'd kind of expect it to also be used by Arm's !CONFIG_STATIC_SHM section - no need to duplicate anything. Jan