On 04/01/2024 11:06 am, Jan Beulich wrote: > On 22.12.2023 16:12, Oleksii Kurochko wrote: >> The <asm/nospec.h> header is similar between Arm, PPC, and RISC-V, >> so it has been moved to asm-generic. >> >> Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> > Acked-by: Jan Beulich <jbeul...@suse.com> > > A word may want saying though on ... > >> --- a/xen/arch/arm/include/asm/nospec.h >> +++ b/xen/include/asm-generic/nospec.h >> @@ -1,8 +1,8 @@ >> -/* SPDX-License-Identifier: GPL-2.0 */ >> -/* Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. >> */ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +#ifndef _ASM_GENERIC_NOSPEC_H >> +#define _ASM_GENERIC_NOSPEC_H > ... the removal of the copyright line.
That isn't a removal of ARM's copyright line. The two files are similar enough to trigger git-diff's "this was a rename" logic (see the a vs b paths), despite not being a rename. It's unfortunate rendering in this case. ~Andrew
