On Mon, 8 Jan 2024 at 20:49, David Woodhouse <dw...@infradead.org> wrote: > > From: David Woodhouse <d...@amazon.co.uk> > > Most code which directly accesses nd_table[] and nb_nics uses them for > one of two things. Either "I have created a NIC device and I'd like a > configuration for it", or "I will create a NIC device *if* there is a > configuration for it". With some variants on the theme around whether > they actually *check* if the model specified in the configuration is > the right one. > > Provide functions which perform both of those, allowing platforms to > be a little more consistent and as a step towards making nd_table[] > and nb_nics private to the net code. > > Also export the qemu_find_nic_info() helper, as some platforms have > special cases they need to handle. > > Signed-off-by: David Woodhouse <d...@amazon.co.uk> > Reviewed-by: Paul Durrant <p...@xen.org> > --- > include/net/net.h | 7 ++++++- > net/net.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 57 insertions(+), 1 deletion(-) > > diff --git a/include/net/net.h b/include/net/net.h > index ffbd2c8d56..25ea83fd12 100644 > --- a/include/net/net.h > +++ b/include/net/net.h > @@ -207,7 +207,12 @@ int qemu_show_nic_models(const char *arg, const char > *const *models); > void qemu_check_nic_model(NICInfo *nd, const char *model); > int qemu_find_nic_model(NICInfo *nd, const char * const *models, > const char *default_model); > - > +NICInfo *qemu_find_nic_info(const char *typename, bool match_default, > + const char *alias); > +bool qemu_configure_nic_device(DeviceState *dev, bool match_default, > + const char *alias); > +DeviceState *qemu_create_nic_device(const char *typename, bool match_default, > + const char *alias);
Could we have doc comments that document the purpose and API for these new global functions, please? thanks -- PMM