On 07.02.2024 01:56, Stefano Stabellini wrote: > On Tue, 6 Feb 2024, Jan Beulich wrote: >> On 02.02.2024 16:16, Simone Ballarin wrote: >>> Rule 13.1: Initializer lists shall not contain persistent side effects >>> >>> This patch moves expressions with side-effects into new variables before >>> the initializer lists. >>> >>> No functional changes. >>> >>> Signed-off-by: Simone Ballarin <simone.balla...@bugseng.com> >> >> To be honest, I don't like this. It's more code for no gain. Really its >> hampering clarity imo. I'm willing to be convinced otherwise, but for >> now this gets a nack from me. > > Which part of the patch you don't like? The changes to > bad_ioapic_register?
Really all of them. bad_ioapic_register() is merely worst. Jan
