Hi Oleksii, On 02/02/2024 18:03, Oleksii Kurochko wrote:
Move the macros mentioned in the commit subject to their appropriate locations. Additionally, eliminate the dependency of xen/lib.h from xen/bug.h and include "xen/bug.h" in files where xen/bug.h macros are utilized.Most of the changes were made because a file requires macros from xen/bug.h, except for some files for Arm which require definitions of BUG_OPCODE, BUG_INSTR, BUG_FN_REG. xen/lib.h was added to list-sort.c ( otherwise compilation errors related to {d}printk occur during compilation of list-sort.c. ) as xen/lib.h was removed from xen/list.h. Since nothing in xen/list.h depends on xen/lib.h functionality and only xen/bug.h is needed. cpufeature.h requires the inclusion of <xen/cache.h>; otherwise, the following error will occur: ld: common/monitor.o:/build/xen/./arch/x86/include/asm/cpufeature.h:41: multiple definitions of `__cacheline_aligned'; Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com>
Acked-by: Julien Grall <jgr...@amazon.com> Cheers, -- Julien Grall
