On Mon, Feb 05, 2024 at 02:57:30PM +0100, Jan Beulich wrote: > ..., thus allowing them to become static. There's nothing x86-specific > about these functions anyway. > > Since only the "iommu_inclusive_mapping" parameter declaration would be > left in the file, move that as well. There's nothing VT-d specific about > it (anymore?): "dom0-iommu=map-inclusive" is similarly generic, and > documentation also doesn't say anything.
Hm, I guess documentation should at least say that iommu_inclusive_mapping is x86 specific, because it's not parsed on Arm and hence might give the wrong impression that it's actually acknowledged there. > Signed-off-by: Jan Beulich <jbeul...@suse.com> Acked-by: Roger Pau Monné <roger....@citrix.com> Albeit I think it would be better to put the parsing in generic iommu.c, so that the option gets parsed on Arm and arch_iommu_hwdom_init() can print a warning message about it not supported on Arm. Thanks, Roger.
