On 2024-02-09 10:28, Julien Grall wrote:
On 09/02/2024 07:52, Nicola Vetrini wrote:
Hi Julien,
Hi Nicola,
On 2024-02-08 22:33, Julien Grall wrote:
Hi Nicola,
On 08/02/2024 07:55, Nicola Vetrini wrote:
These two files contain several deliberate violations of MISRA C
rules and
they are not linked in the final Xen binary, therefore they can be
exempted
from MISRA compliance.
I am curious, what are the violations you are talking about?
Cheers,
The one that prompted the exclusion is for R20.12 on arm for the
macros DEFINE and OFFSET, where the second argument of OFFSET is a
macro and is used as a normal parameter and a stringification operand.
However, there are other special cases (e.g., the file not being
linked, which violates R2.1 and was already decided to deviate that
aspect).
Thanks for the clarification. I think it would be worth to add what you
just wrote in the commit message. This give an idea to the reviewer why
we excluded it.
With Jan's request addressed:
Acked-by: Julien Grall <jgr...@amazon.com>
Thanks. I did send a v2 of this patch addressing Jan's request. I'll let
him decide whether he wants a more detailed commit message.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
