Hi Jan,

On 3/12/2024 12:58 AM, Jan Beulich wrote:
On 08.03.2024 02:54, Henry Wang wrote:
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -946,6 +946,25 @@ struct xen_domctl_paging_mempool {
      uint64_aligned_t size; /* Size in bytes. */
  };
+#define XEN_MAX_MEM_REGIONS 1
+
+struct xen_mem_region {
+    uint64_t start;
+    uint64_t size;
uint64_aligned_t?

Yes this makes great sense, thanks for catching it here and ...

+    unsigned int type;
uint32_t and explicit padding (incl checking thereof) please.

...here and ...

+};
+typedef struct xen_mem_region xen_mem_region_t;
+DEFINE_XEN_GUEST_HANDLE(xen_mem_region_t);
+
+struct xen_domctl_mem_map {
+    /* IN & OUT */
+    uint32_t nr_mem_regions;
+    /* OUT */
+    XEN_GUEST_HANDLE(xen_mem_region_t) buffer;
XEN_GUEST_HANDLE_64() and explicit padding (+checking) again please.

...here. I will update the patch accordingly and add the padding + checking in v3.

Kind regards,
Henry

Jan


Reply via email to