On 19.03.2024 12:30, Andrew Cooper wrote:
> The single user wants this the sane way around. Write it as a normal static
> inline just like rspin_lock().
>
> Fixes: cc3e8df542ed ("xen/spinlock: add rspin_[un]lock_irq[save|restore]()")
> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Notwithstanding Jürgen's R-b I'd be quite a bit happier if (a) this and
spin_lock_irqsave() remained consistent with one another or at least
(b) the implications of doing the necessary transformation for the
latter towards Linux compatibility were visible to have been considered,
in particular with it in mind that Misra won't like
#define spin_lock_irqsave(l, f) \
({ \
BUILD_BUG_ON(sizeof(f) != sizeof(unsigned long)); \
(f) = spin_lock_irqsave(l); \
})
in linux-compat.h (and obviously with xen/spinlock.h included ahead of
this).
Jan
