On Wed, Mar 20, 2024 at 12:16 PM George Dunlap <george.dun...@cloud.com> wrote: > > On Mon, Mar 18, 2024 at 4:36 PM Andrew Cooper <andrew.coop...@citrix.com> > wrote: > > > > There is no need for bitfields anywhere - use more sensible types. There is > > also no need to cast 'd' to (unsigned char *) before passing it to a > > function > > taking void *. Switch to new trace_time() API. > > > > No functional change. > > Hey Andrew -- overall changes look great, thanks for doing this very > detailed work.
For my own posterity later: I've done a close review of the rest of the patch and didn't see any issues other than the loss of sign in a handful of cases. -George
