On 29.03.2024 19:23, Oleksii wrote: > On Wed, 2024-03-20 at 16:42 +0100, Jan Beulich wrote: >> On 15.03.2024 19:06, Oleksii Kurochko wrote: >>> --- a/xen/lib/find-next-bit.c >>> +++ b/xen/lib/find-next-bit.c >>> @@ -9,6 +9,7 @@ >>> * 2 of the License, or (at your option) any later version. >>> */ >>> #include <xen/bitops.h> >>> +#include <xen/linux-compat.h> >>> >>> #include <asm/byteorder.h> >> >> Hmm, no, a library source would better not include this header. >> Surely >> the ffz() can be taken care of locally here? > Except that __ffs() from xen/linux-compat.h is used in find-next-bit.c, > so it seems that it is still need to include the header.
Hmm, no - that __ffs() use, if we mean that to become a Linux compat thing only, should then be replaced (or covered locally), too, imo. Jan
