On 04.04.2024 09:51, Michal Orzel wrote:
> On Arm we don't use console_{suspend,resume} and the corresponding
> stubs in serial drivers are being redundantly copied whenever a new
> driver is added. Drop them as well as useless .endboot = NULL assignment.
> 
> Signed-off-by: Michal Orzel <michal.or...@amd.com>

Since hook invocations are suitably guarded:
Reviewed-by: Jan Beulich <jbeul...@suse.com>

However, from a Misra perspective more wants doing here if suspend/resume
indeed isn't wanted / needed on Arm: console_{suspend,resume}() are
unreachable there, and hence want hiding behind some (presumably)
CONFIG_HAS_*. In turn the two hooks then would also want making conditional
upon that option actually being selected by an architecture.

Jan

Reply via email to