On 17.05.2024 13:14, Chen, Jiqian wrote: > On 2024/5/17 18:51, Jan Beulich wrote: >> On 17.05.2024 12:45, Chen, Jiqian wrote: >>> On 2024/5/16 22:01, Jan Beulich wrote: >>>> On 16.05.2024 11:52, Jiqian Chen wrote: >>>>> + if ( gsi >= nr_irqs_gsi ) >>>>> + { >>>>> + ret = -EINVAL; >>>>> + break; >>>>> + } >>>>> + >>>>> + if ( !irq_access_permitted(current->domain, gsi) || >>>> >>>> I.e. assuming IRQ == GSI? Is that a valid assumption when any number of >>>> source overrides may be surfaced by ACPI? >>> All irqs smaller than nr_irqs_gsi are gsi, aren't they? >> >> They are, but there's not necessarily a 1:1 mapping. > Oh, so do I need to add a new gsi_caps to store granted gsi?
Probably not. You ought to be able to translate between GSI and IRQ, and then continue to record in / check against IRQ permissions. Jan