On 22/05/2024 11:17 am, Jan Beulich wrote: > The emulation_count field is set only conditionally right now. Convert > all field setting to an initializer, thus guaranteeing that field to be > set to 0 (default initialized) when GUEST_PAGING_LEVELS != 3. > > While there also drop the "event" local variable, thus eliminating an > instance of the being phased out u32 type. > > Coverity ID: 1598430 > Fixes: 9a86ac1aa3d2 ("xentrace 5/7: Additional tracing for the shadow code") > Signed-off-by: Jan Beulich <jbeul...@suse.com>
This is an improvement, but there's a related mess right next to it. I think this would be a whole lot better with a couple of tweaks, if you're willing to wait a little for me to try. ~Andrew