Le 23/05/2024 à 11:52, Roger Pau Monné a écrit :
> The #ifdef and #endif processor directives shouldn't be indented.
>
> Would you mind adding /* CONFIG_{AMD,INTEL}_IOMMU */ comments in the
> #endif directives?
>Sure, will change it for v2. > I wonder if we could move the definitions of those structures to the > vendor specific headers, but that's more convoluted, and would require > including the iommu headers in pci.h Do you mean moving the vtd/amd union entries to separate structures (e.g vtd_arch_iommu) and put them into another file (I don't see any vendor-specific headers for this, perhaps create ones ?). > > Thanks, Roger. Teddy Teddy Astie | Vates XCP-ng Intern XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech
