Re: [PATCH 5/6] ARM/vgic: Use for_each_set_bit() in vgic_set_irqs_pending()

[Michal Orzel]

On 25/06/2024 21:07, Andrew Cooper wrote:
> 
> 
> ... which is better optimised for scalar values, rather than using the
> arbitrary-sized bitmap helpers.
> 
> For ARM32:
> 
>   add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-16 (-16)
>   Function                                     old     new   delta
>   vgic_set_irqs_pending                        284     268     -16
> 
> including removing calls to _find_{first,next}_bit_le(), and two stack-spilled
> words too.
> 
> For ARM64:
> 
>   add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-40 (-40)
>   Function                                     old     new   delta
>   vgic_set_irqs_pending                        268     228     -40
> 
> including removing three calls to find_next_bit().
> 
> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Michal Orzel <michal.or...@amd.com>

~Michal