On 18.06.24 11:42, Viresh Kumar wrote:
irqfd_wakeup() gets EPOLLHUP, when it is called by eventfd_release() by way of wake_up_poll(&ctx->wqh, EPOLLHUP), which gets called under spin_lock_irqsave(). We can't use a mutex here as it will lead to a deadlock.Fix it by switching over to a spin lock. Reported-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org> --- drivers/xen/privcmd.c | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 67dfa4778864..5ceb6c56cf3e 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -13,7 +13,6 @@ #include <linux/file.h> #include <linux/kernel.h> #include <linux/module.h> -#include <linux/mutex.h>
I don't think you can drop that. There is still the ioreq_lock mutex. I can fix that up while committing, with that: Reviewed-by: Juergen Gross <jgr...@suse.com> Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
