On 01/07/2024 3:47 pm, Matthew Barnes wrote:
> diff --git a/tools/misc/xen-hvmcrash.c b/tools/misc/xen-hvmcrash.c
> index 1d058fa40a47..efa47c9dfec8 100644
> --- a/tools/misc/xen-hvmcrash.c
> +++ b/tools/misc/xen-hvmcrash.c
> @@ -77,65 +66,22 @@ main(int argc, char **argv)
> exit(1);
> }
>
> - ret = xc_domain_pause(xch, domid);
> - if (ret < 0) {
> - perror("xc_domain_pause");
> - exit(-1);
> - }
You can't really drop the xc_domain_{un,}pause() calls.
Previously, from the point of view of the guest, we atomically corrupted
all vCPUs at once.
Without the pause, we're corrupting each vCPU in turn, with the guest
able to run in the meantime.
~Andrew
