On 2024/7/8 18:32, Andrew Cooper wrote:
> On 08/07/2024 9:04 am, Jiqian Chen wrote:
>> Fix bug introduced by 0762e2502f1f ("x86/physdev: factor out the code to
>> allocate and
>> map a pirq"). After that re-factoring, when pirq<0 and current_pirq>0, it
>> means
>> caller want to allocate a free pirq for irq but irq already has a mapped
>> pirq, then
>> it returns the negative pirq, so it fails. However, the logic before that
>> re-factoring is different, it should return the current_pirq that irq was
>> already
>> mapped to and make the call success.
>>
>> Fixes: 0762e2502f1f ("x86/physdev: factor out the code to allocate and map a
>> pirq")
>>
>> Signed-off-by: Jiqian Chen <jiqian.c...@amd.com>
>> Signed-off-by: Huang Rui <ray.hu...@amd.com>
>> Signed-off-by: Jiqian Chen <jiqian.c...@amd.com>
>> Reviewed-by: Jan Beulich <jbeul...@suse.com>
>
> As a minor note, we treat Fixes: as a tag like all the others, so tend
> not to have a blank line between it an the SoB.
Learned it, thank you!
>
> Can be fixed on commit - no need to resend.
>
> ~Andrew
--
Best regards,
Jiqian Chen.
