The paths shouldn't be set to "yes".
Reported-by: Anthony Perard <anthony.per...@citrix.com>
Signed-off-by: Wei Liu <wei.l...@citrix.com>
---
v3: really check for absolute paths.
Cc: Ian Jackson <ian.jack...@eu.citrix.com>
new in v2
---
tools/configure | 9 ++++++---
tools/configure.ac | 9 ++++++---
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/tools/configure b/tools/configure
index 4bff2c02fd..3b55fb2e36 100755
--- a/tools/configure
+++ b/tools/configure
@@ -4564,7 +4564,8 @@ if test "${with_system_seabios+set}" = set; then :
seabios=n
case $withval in
no) seabios_path= ;;
- *) seabios_path=$withval ;;
+ /*) seabios_path=$withval ;;
+ *) as_fn_error $? "Seabios specified, but is not an absolute path"
"$LINENO" 5 ;;
esac
fi
@@ -4587,7 +4588,8 @@ if test "${with_system_ovmf+set}" = set; then :
ovmf=n
case $withval in
no) ovmf_path= ;;
- *) ovmf_path=$withval ;;
+ /*) ovmf_path=$withval ;;
+ *) as_fn_error $? "OVMF specified, but is not an absolute path"
"$LINENO" 5 ;;
esac
fi
@@ -4610,7 +4612,8 @@ if test "${with_system_ipxe+set}" = set; then :
ipxe=n
case $withval in
no) ipxe_path= ;;
- *) ipxe_path=$withval ;;
+ /*) ipxe_path=$withval ;;
+ *) as_fn_error $? "IPXE specified, but is not an absolute path"
"$LINENO" 5 ;;
esac
# IPXE depends on Rombios
diff --git a/tools/configure.ac b/tools/configure.ac
index 2db2356380..0f85472602 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -216,7 +216,8 @@ AC_ARG_WITH([system-seabios],
seabios=n
case $withval in
no) seabios_path= ;;
- *) seabios_path=$withval ;;
+ /*) seabios_path=$withval ;;
+ *) AC_MSG_ERROR([Seabios specified, but is not an absolute path]) ;;
esac
],[])
AS_IF([test "x$seabios" = "xy" -o -n "$seabios_path" ], [
@@ -233,7 +234,8 @@ AC_ARG_WITH([system-ovmf],
ovmf=n
case $withval in
no) ovmf_path= ;;
- *) ovmf_path=$withval ;;
+ /*) ovmf_path=$withval ;;
+ *) AC_MSG_ERROR([OVMF specified, but is not an absolute path]) ;;
esac
],[])
AS_IF([test "x$ovmf" = "xy" -o -n "$ovmf_path" ], [
@@ -250,7 +252,8 @@ AC_ARG_WITH([system-ipxe],
ipxe=n
case $withval in
no) ipxe_path= ;;
- *) ipxe_path=$withval ;;
+ /*) ipxe_path=$withval ;;
+ *) AC_MSG_ERROR([IPXE specified, but is not an absolute path]) ;;
esac
# IPXE depends on Rombios
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
