On Thu Sep 5, 2024 at 2:06 PM BST, Andrew Cooper wrote: > This removes a level of indirection, as well as removing a somewhat misleading > name; the variable is really "S3 video quirks".
nit: Would it be beneficial to rename video_flags to s3_video_flags? > > More importantly however it makes it very clear that, right now, parsing the > cmdline and quirks depends on having already placed the trampoline; a > dependency which is going to be gnarly to untangle. > > That said, fixing the quirk is easy. The Toshiba Satellite 4030CDT has an > Intel Celeron 300Mhz CPU (Pentium 2 era) from 1998 when MMX was the headline > feature, sporting 64M of RAM. Being a 32-bit processor, it hasn't been able > to run Xen for about a decade now, so drop the quirk entirely. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Roger Pau Monné <roger....@citrix.com> > CC: Frediano Ziglio <frediano.zig...@cloud.com> > CC: Alejandro Vallejo <alejandro.vall...@cloud.com> > --- > xen/arch/x86/acpi/power.c | 2 +- > xen/arch/x86/dmi_scan.c | 12 ------------ > xen/arch/x86/include/asm/acpi.h | 1 - > 3 files changed, 1 insertion(+), 14 deletions(-) Always nice to see old hacks disappear. Reviewed-by: Alejandro Vallejo <alejandro.vall...@cloud.com> Cheers, Alejandro
