On 10/09/2024 10:12 am, Jan Beulich wrote: > On 10.09.2024 10:48, Nicola Vetrini wrote: >> Rule 7.3 states: >> "The lowercase character l shall not be used in a literal suffix", >> but the INTEL_MSR_RANGE macro uses the "ull" suffix. >> The "u" is transformed in uppercase for consistency. >> >> No functional change. >> >> Signed-off-by: Nicola Vetrini <[email protected]> > Acked-by: Jan Beulich <[email protected]> > > I'm heavily tempted though to ... > >> --- a/xen/arch/x86/acpi/cpufreq/acpi.c >> +++ b/xen/arch/x86/acpi/cpufreq/acpi.c >> @@ -25,7 +25,7 @@ enum { >> SYSTEM_IO_CAPABLE, >> }; >> >> -#define INTEL_MSR_RANGE (0xffffull) >> +#define INTEL_MSR_RANGE (0xffffULL) > ... drop the pointless parentheses while committing.
I'd be tempted to delete the constant entirely. It's utterly wrong and unsafe everywhere it's used... ~Andrew
