On 25/09/2024 9:42 am, Roger Pau Monne wrote:
> The current check for duplicated sections in a payload is not effective. Such
> check is done inside a loop that iterates over the sections names, it's
> logically impossible for the bitmap to be set more than once.
>
> The usage of a bitmap in check_patching_sections() has been replaced with a
> boolean, since the function just cares that at least one of the special
> sections is present.
>
> No functional change intended, as the check was useless.
>
> Fixes: 29f4ab0b0a4f ('xsplice: Implement support for
> applying/reverting/replacing patches.')
> Fixes: 76b3d4098a92 ('livepatch: Do not enforce ELF_LIVEPATCH_FUNC section
> presence')
> Signed-off-by: Roger Pau Monné <roger....@citrix.com>
Yes I agree. This is useless logic.
The only time we could spot such a case is when matching the section
table with the string table. For this logic, we always only get
whichever answer livepatch_elf_sec_by_name() decides.
Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> and I'm very
happy to see some atomics disappear.
