Hi Oleksii,
On 26/09/2024 18:54, Oleksii Kurochko wrote:
>
>
> Refactor arm/xen.lds.S by replacing the inline definitions for
> device info sections with the newly introduced {DT,ACPI}_DEV_INFO
> macros from xen/xen.lds.h.
I would expect so see a note about s/8/POINTER_ALIGN/ that it's safe to do that.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com>
> ---
> Changes in V4:
> - use newly refactored ACPI_DEV_INFO and DT_DEV_INFO
> ---
> Changes in V3:
> - use refactored ADEV_INFO and DT_DEV_INFO macros.
> ---
> xen/arch/arm/xen.lds.S | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index 0987052f1a..3b7b677197 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -4,6 +4,8 @@
>
> #include <xen/cache.h>
> #include <xen/lib.h>
> +
> +#define SIMPLE_DECL_SECTION
> #include <xen/xen.lds.h>
> #include <asm/page.h>
> #undef ENTRY
> @@ -124,20 +126,10 @@ SECTIONS
> _eplatform = .;
> } :text
>
> - . = ALIGN(8);
> - .dev.info : {
> - _sdevice = .;
> - *(.dev.info)
> - _edevice = .;
> - } :text
> + DT_DEV_INFO(.dev.info)
>
> #ifdef CONFIG_ACPI
> - . = ALIGN(8);
> - .adev.info : {
The name of the section is ".adev.info", but ...
> - _asdevice = .;
> - *(.adev.info)
> - _aedevice = .;
> - } :text
> + ACPI_DEV_INFO(adev.info)
here you're missing the leading dot which will cause the probe to fail.
Apart from that:
Reviewed-by: Michal Orzel <michal.or...@amd.com>
~Michal
