Re: [PATCH v6 13/44] x86/boot: transition relocation calculations to struct boot_module

[Daniel P. Smith]

On 10/18/24 02:39, Jan Beulich wrote:

On 18.10.2024 02:42, Jason Andryuk wrote:

On 2024-10-17 13:02, Daniel P. Smith wrote:

@@ -1686,12 +1682,12 @@ void asmlinkage __init noreturn __start_xen(unsigned 
long mbi_p)

for ( i = 0; i < bi->nr_modules; ++i )

       {
-        set_pdx_range(bi->mods[i].mod->mod_start,
-                      bi->mods[i].mod->mod_start +
-                      PFN_UP(bi->mods[i].mod->mod_end));
-        map_pages_to_xen((unsigned 
long)mfn_to_virt(bi->mods[i].mod->mod_start),
-            _mfn(bi->mods[i].mod->mod_start),
-            PFN_UP(bi->mods[i].mod->mod_end), PAGE_HYPERVISOR);
+        set_pdx_range(paddr_to_pfn(bi->mods[i].start),
+                      paddr_to_pfn(bi->mods[i].start) +
+                      PFN_UP(bi->mods[i].size));
+        map_pages_to_xen((unsigned long)maddr_to_virt(bi->mods[i].start),
+            maddr_to_mfn(bi->mods[i].start),
+            PFN_UP(bi->mods[i].size), PAGE_HYPERVISOR);

I would vertically align all the parameters inside the (.

At the very least the two successive calls want formatting the same way.
Plus imo the presented formatting of map_pages_to_xen() isn't "legal"
anyway, it ought to be

         map_pages_to_xen(
             (unsigned long)maddr_to_virt(bi->mods[i].start),
             maddr_to_mfn(bi->mods[i].start),
             PFN_UP(bi->mods[i].size), PAGE_HYPERVISOR);

Agreed, will change to the above.

v/r,
dps