Hi Ayan,
sorry I've just spotted some issues while compiling
> diff --git a/xen/arch/arm/include/asm/early_printk.h
> b/xen/arch/arm/include/asm/early_printk.h
> index 46a5e562dd..606aaedd6e 100644
> --- a/xen/arch/arm/include/asm/early_printk.h
> +++ b/xen/arch/arm/include/asm/early_printk.h
> @@ -15,6 +15,29 @@
you need to include
#include <asm/arm64/mpu.h>
in order to see MPU_REGION_ALIGN which otherwise will be zero for the
preprocessor
>
> #ifdef CONFIG_EARLY_PRINTK
>
> +#if defined(CONFIG_MPU)
> +
> +/*
> + * For MPU systems, there is no VMSA support in EL2, so we use VA == PA
> + * for EARLY_UART_VIRTUAL_ADDRESS.
> + */
> +#define EARLY_UART_VIRTUAL_ADDRESS CONFIG_EARLY_UART_BASE_ADDRESS
> +
> +/*
> + * User-defined EARLY_UART_BASE_ADDRESS and EARLY_UART_SIZE must be aligned
> to
> + * minimum size of MPU region.
> + */
> +
> +#if (EARLY_UART_BASE_ADDRESS % MPU_REGION_ALIGN) != 0
^— This needs to be CONFIG_*
> +#error "EARLY_UART_BASE_ADDRESS must be aligned to minimum MPU region size"
> +#endif
> +
> +#if (EARLY_UART_SIZE % MPU_REGION_ALIGN) != 0
^— This needs to be CONFIG_*
Once these are addressed and taking care also of Julien's comment:
Reviewed-by: Luca Fancellu <[email protected]
<mailto:[email protected]>>
Cheers,
Luca
