Re: [PATCH for-4.20] x86/HVM: use XVFREE() in hvmemul_cache_destroy()

[Oleksii Kurochko]

On 2/13/25 12:10 PM, Jan Beulich wrote:

My adjustments to move from xmalloc() et al to respective xvmalloc()
flavors was flawed - a freeing instance wasn't converted.

Fixes: 23d60dbb0493 ("x86/HVM: allocate emulation cache entries dynamically")
Signed-off-by: Jan Beulich<jbeul...@suse.com>
---
Noticed while backporting, where the conversion needs undoing.

Release-Acked-By: Oleksii Kurochko<oleksii.kuroc...@gmail.com>

~ Oleksii

--- a/xen/arch/x86/include/asm/hvm/emulate.h
+++ b/xen/arch/x86/include/asm/hvm/emulate.h
@@ -123,7 +123,7 @@ static inline void hvmemul_cache_destroy(struct vcpu *v)
      unsigned int i;

for ( i = 0; i < ARRAY_SIZE(v->arch.hvm.hvm_io.mmio_cache); ++i )

-        XFREE(v->arch.hvm.hvm_io.mmio_cache[i]);
+        XVFREE(v->arch.hvm.hvm_io.mmio_cache[i]);
      XVFREE(v->arch.hvm.hvm_io.cache);
  }
  bool hvmemul_read_cache(const struct vcpu *v, paddr_t gpa,