On Thu, 13 Feb 2025, Marek Marczykowski-Górecki wrote: > > > diff --git a/automation/scripts/run-tools-tests > > > b/automation/scripts/run-tools-tests > > > new file mode 100755 > > > index 000000000000..242a9edad941 > > > --- /dev/null > > > +++ b/automation/scripts/run-tools-tests > > > @@ -0,0 +1,47 @@ > > > +#!/bin/sh > > > > It should be /bin/bash > > That script is running inside SUT (started from initramfs) which is > rather minimal. I think it currently has bash, but with the initramfs at > over 200MB (compressed) I can see trimming it in the future...
Hi Marek, let me clarify a bit more my comment. While I have a preference for bash because that is what we are using for all the other shell scripts, it is OK to use /bin/sh but then we need to make sure the script is actually /bin/sh compatible and doesn't have any bash-isms. Eye-balling the script I had the impression it was using bash-isms, so I made the comment about using /bin/bash. But in my experience most /bin/sh implementations today they are actually somewhat bash compatible, so in general it is easier to declare /bin/bash instead of /bin/sh.
