On 11.03.2025 16:27, Roger Pau Monne wrote:
> The current usage of msi_desc->msg in vmx_pi_update_irte() will make the
> field contain a translated MSI message, instead of the expected
> untranslated one. This breaks dump_msi(), that use the data in
> msi_desc->msg to print the interrupt details.
>
> Fix this by introducing a dummy local msi_msg, and use it with
> iommu_update_ire_from_msi(). vmx_pi_update_irte() relies on the MSI
> message not changing, so there's no need to propagate the resulting msi_msg
> to the hardware, and the contents can be ignored.
>
> Additionally add a comment to clarify that msi_desc->msg must always
> contain the untranslated MSI message.
>
> Fixes: a5e25908d18d ('VT-d: introduce new fields in msi_desc to track binding
> with guest interrupt')
> Signed-off-by: Roger Pau Monné <[email protected]>
Reviewed-by: Jan Beulich <[email protected]>